Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 8370024: aura: Add mouse wheel event support for x11 in RWHVA. (Closed)

Created:
9 years, 2 months ago by sadrul
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

aura: Add mouse wheel event support for x11 in RWHVA. BUG=99757 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
9 years, 2 months ago (2011-10-22 21:36:31 UTC) #1
Ben Goodger (Google)
WebMouseWheelEvent is a subclass of WebMouseEvent... I think this means you have to fill in ...
9 years, 2 months ago (2011-10-22 21:43:09 UTC) #2
sadrul
On 2011/10/22 21:43:09, Ben Goodger (Google) wrote: > WebMouseWheelEvent is a subclass of WebMouseEvent... I ...
9 years, 2 months ago (2011-10-22 21:45:26 UTC) #3
Ben Goodger (Google)
9 years, 2 months ago (2011-10-22 21:46:04 UTC) #4
Oh, duh. LGTM then.

On Sat, Oct 22, 2011 at 2:45 PM, <sadrul@chromium.org> wrote:

> On 2011/10/22 21:43:09, Ben Goodger (Google) wrote:
>
>> WebMouseWheelEvent is a subclass of WebMouseEvent... I think this means
>> you
>> have to fill in the mouseevent properties (like x,y etc) too.
>>
>
> MakeWebMouseEventFromAuraEven also doesn't fill in x,y etc. This is
> currently
> intentional, since they get reset in the calling function
> (MakeWebMouseWheelEvent) immediately afterwards.
>
>
>
>  -Ben
>>
>
>  On Sat, Oct 22, 2011 at 2:36 PM, <mailto:sadrul@chromium.org> wrote:
>>
>
>  > Reviewers: Ben Goodger (Google),
>> >
>> > Description:
>> > aura: Add mouse wheel event support for x11 in RWHVA.
>> >
>> > BUG=none
>> > TEST=manually
>> >
>> >
>> > Please review this at
>>
>
> http://codereview.chromium.****org/8370024/%3Chttp://coderevi**
> ew.chromium.org/8370024/ <http://codereview.chromium.org/8370024/>>
>
>> >
>> > SVN Base:
>>
>
>
svn://svn.chromium.org/chrome/****trunk/src<http://svn.chromium.org/chrome/**trunk/src>
>
<http://svn.**chromium.org/chrome/trunk/src<http://svn.chromium.org/chrome/tru...
> >
>
>> >
>> > Affected files:
>> >  M content/browser/renderer_host/****web_input_event_aurax11.cc
>> >
>> >
>> > Index: content/browser/renderer_host/****web_input_event_aurax11.cc
>> > diff --git a/content/browser/renderer_****
>> host/web_input_event_aurax11.****cc
>> > b/content/browser/renderer_****host/web_input_event_aurax11.****cc
>> > index 44879fdca6f88d1b9b2d6a05317433****52d4b851ec..**
>> > 2360cc9140556dbca238d4d23741d7****42be568b0c 100644
>> > --- a/content/browser/renderer_****host/web_input_event_aurax11.****cc
>> > +++ b/content/browser/renderer_****host/web_input_event_aurax11.****cc
>> > @@ -254,7 +254,14 @@ WebKit::WebMouseEvent
>> MakeWebMouseEventFromAuraEvent***
>> > *(aura::MouseEvent* event) {
>> >  WebKit::WebMouseWheelEvent MakeWebMouseWheelEventFromAura****Event(
>>
>> >     aura::MouseEvent* event) {
>> >   WebKit::WebMouseWheelEvent webkit_event;
>> > -  // TODO(sadrul): !
>> > +
>> > +  webkit_event.type = WebKit::WebInputEvent::****MouseWheel;
>> > +  webkit_event.button = WebKit::WebMouseEvent::****ButtonNone;
>> > +  webkit_event.modifiers = EventFlagsToWebEventModifiers(****
>> > event->flags());
>> > +  webkit_event.timeStampSeconds = event->time_stamp().ToDoubleT(****);
>> > +  webkit_event.deltaY = ui::GetMouseWheelOffset(event-**
>> **>native_event());
>>
>> > +  webkit_event.wheelTicksY = webkit_event.deltaY > 0 ? 1 : -1;
>> > +
>> >   return webkit_event;
>> >  }
>> >
>> >
>> >
>> >
>>
>
>
>
>
http://codereview.chromium.**org/8370024/<http://codereview.chromium.org/8370...
>

Powered by Google App Engine
This is Rietveld 408576698