Add a new field trial for Instant.

Add a new field trial for Instant.

In this mode, we issue queries as the user types, but don't show the preview.
The name HIDDEN seems more appropriate here, so I've usurped that name for this
trial, renaming the earlier one to SILENT (since it doesn't speak the queries
over the wire).

BUG=none
TEST=interactive_ui_tests InstantFieldTrial*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107053

[sreeram, 2011-10-22 03:38:52]

Please review.

[sky, 2011-10-24 15:03:31]

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_controller.cc (right):

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_controller.cc:186: // For the HIDDEN field trial,
never send back suggestions to the omnibox.
This is a bit obscure. How about moving this after the call to UpdateLoader and
replace with suggested_text->clear()

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_controller.cc:479:
InstantFieldTrial::IsHiddenExperiment(tab_contents_->profile()))) {
Make this part of setting displayable.

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_field_trial.h (right):

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_field_trial.h:33: // SILENT_EXPERIMENT: No
queries are issued until the user presses <Enter>. No
How about HIDDEN_UNTIL_COMMIT?

[sreeram, 2011-10-24 17:14:50]

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_controller.cc (right):

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_controller.cc:186: // For the HIDDEN field trial,
never send back suggestions to the omnibox.
On 2011/10/24 15:03:31, sky wrote:
> This is a bit obscure. How about moving this after the call to UpdateLoader
and
> replace with suggested_text->clear()

Done.

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_controller.cc:479:
InstantFieldTrial::IsHiddenExperiment(tab_contents_->profile()))) {
On 2011/10/24 15:03:31, sky wrote:
> Make this part of setting displayable.

Done.

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_field_trial.h (right):

http://codereview.chromium.org/8370020/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_field_trial.h:33: // SILENT_EXPERIMENT: No
queries are issued until the user presses <Enter>. No
On 2011/10/24 15:03:31, sky wrote:
> How about HIDDEN_UNTIL_COMMIT?

I prefer SILENT. The other field trial is also "hidden until commit" (i.e., the
preview_contents is not shown until commit). The difference is that this
experiment doesn't send any queries over the wire, which I think is captured
well by the name "SILENT".

[sky, 2011-10-24 17:23:49]

LGTM