Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 8370019: Change the delay loading of user32.dll to content_browser (Closed)

Created:
9 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Change the delay loading of user32.dll to content_browser Because other binaries, besides chrome.dll need this, or else they will fail to load on vista or xp, once we remove the manual binding to win7-only apis. BUG=none TEST= waterfall is not red Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 2 months ago (2011-10-22 02:22:34 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 2 months ago (2011-10-22 02:24:03 UTC) #2
M-A Ruel
lgtm FYI, you can set TBR=<reviewer email> to bypass the lgtm check,.as explained in the ...
9 years, 2 months ago (2011-10-22 11:51:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/8370019/1
9 years, 2 months ago (2011-10-22 18:07:45 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-22 21:12:07 UTC) #5
M-A Ruel
Someone broke the CQ today, I'll figuring out the bad rev and will check the ...
9 years, 2 months ago (2011-10-22 21:32:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/8370019/1
9 years, 2 months ago (2011-10-23 09:15:05 UTC) #7
commit-bot: I haz the power
Failed to send try job 8370019-1: 2
9 years, 2 months ago (2011-10-23 09:15:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/8370019/1
9 years, 2 months ago (2011-10-23 13:07:20 UTC) #9
commit-bot: I haz the power
Failed to send try job 8370019-1: 2
9 years, 2 months ago (2011-10-23 13:07:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/8370019/1
9 years, 2 months ago (2011-10-24 17:35:38 UTC) #11
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 18:49:56 UTC) #12
Change committed as 106950

Powered by Google App Engine
This is Rietveld 408576698