Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: vm/message_queue.cc

Issue 8370016: Revert https://code.google.com/p/dart/source/detail?r=597 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | vm/thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/message_queue.h" 5 #include "vm/message_queue.h"
6 6
7 namespace dart { 7 namespace dart {
8 8
9 MessageQueue::~MessageQueue() { 9 MessageQueue::~MessageQueue() {
10 // Ensure that all pending messages have been released. 10 // Ensure that all pending messages have been released.
(...skipping 22 matching lines...) Expand all
33 tail_ = msg; 33 tail_ = msg;
34 } 34 }
35 35
36 monitor_.Exit(); 36 monitor_.Exit();
37 } 37 }
38 38
39 39
40 PortMessage* MessageQueue::Dequeue(int64_t millis) { 40 PortMessage* MessageQueue::Dequeue(int64_t millis) {
41 MonitorLocker ml(&monitor_); 41 MonitorLocker ml(&monitor_);
42 PortMessage* result = head_; 42 PortMessage* result = head_;
43 // Wait may wake up prematurely, so we need to loop until result != NULL 43 if (result == NULL) {
44 while (result == NULL) {
45 ml.Wait(millis); 44 ml.Wait(millis);
46 result = head_; 45 result = head_;
47 // If there's a time-out the caller must check for NULL anyway.
48 if (0 < millis)
49 break;
50 } 46 }
51 if (result != NULL) { 47 if (result != NULL) {
52 head_ = result->next_; 48 head_ = result->next_;
53 // The following update to tail_ is not strictly needed. 49 // The following update to tail_ is not strictly needed.
54 if (head_ == NULL) { 50 if (head_ == NULL) {
55 tail_ = NULL; 51 tail_ = NULL;
56 } 52 }
57 #if DEBUG 53 #if DEBUG
58 result->next_ = result; // Make sure to trigger ASSERT in Enqueue. 54 result->next_ = result; // Make sure to trigger ASSERT in Enqueue.
59 #endif // DEBUG 55 #endif // DEBUG
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 tail_ = NULL; 90 tail_ = NULL;
95 while (cur != NULL) { 91 while (cur != NULL) {
96 PortMessage* next = cur->next_; 92 PortMessage* next = cur->next_;
97 delete cur; 93 delete cur;
98 cur = next; 94 cur = next;
99 } 95 }
100 } 96 }
101 97
102 98
103 } // namespace dart 99 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | vm/thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698