chrome/browser/sync/glue/typed_url_model_associator.h - Issue 8370011: Now does not sync URLs that only have imported visits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_model_associator.h

Issue 8370011: Now does not sync URLs that only have imported visits. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Improved integration test to also test case of visiting url after sync. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/typed_url_model_associator.h

diff --git a/chrome/browser/sync/glue/typed_url_model_associator.h b/chrome/browser/sync/glue/typed_url_model_associator.h

index 87de4e507b55910279e6c7ae516504778ce129e5..e875ecc02075b51072d7976563dbbb930a84786a 100644

--- a/chrome/browser/sync/glue/typed_url_model_associator.h

+++ b/chrome/browser/sync/glue/typed_url_model_associator.h

@@ -166,6 +166,11 @@ class TypedUrlModelAssociator

// association map.

bool IsAssociated(const std::string& node_tag);

+ // Helper function that determines if we should ignore a URL for the purposes

+ // of sync, because it's import-only.

+ bool ShouldIgnoreUrl(const history::URLRow& url,

+ const history::VisitVector& visits);

ProfileSyncService* sync_service_;

history::HistoryBackend* history_backend_;

int64 typed_url_node_id_;