Now does not sync URLs that only have imported visits.

Now does not sync URLs that only have imported visits.

During ModelAssociation we ignore URLs that only contain imported visits. We
still look at them in the change processor because we still want to sync them
if the user ever visits the URLs in Chrome.

BUG=99963
TEST=Run firefox, visit URLs, run chrome with fresh profile, see imported URLs are not synced.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106853

[Andrew T Wilson (Slow), 2011-10-21 22:42:31]

Scott, if you could look at the browser/history stuff, I'd appreciate it. I
basically just plumbed GetVisitsSource() up through HistoryBackend, and also
changed the unit tests to use this routine to get some test coverage.

[sky, 2011-10-21 22:44:51]

Non-virtual, add description (including return value) and browser/history LGTM

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/history/histo...
File chrome/browser/history/history_backend.h (right):

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/history/histo...
chrome/browser/history/history_backend.h:304: virtual bool GetVisitsSource(const
VisitVector& visits,
Does this really need to be virtual?
Add a description too.

[tim (not reviewing), 2011-10-22 05:37:13]

sync LGTM

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/sync/glue/typ...
File chrome/browser/sync/glue/typed_url_model_associator.cc (right):

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/sync/glue/typ...
chrome/browser/sync/glue/typed_url_model_associator.cc:105: // We ignore URLs
that have never been visited by chromium (i.e. all visits
'all visits that were imported'?

[Andrew T Wilson (Slow), 2011-10-22 06:48:21]

Thanks for the quick turnaround on the review!

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/history/histo...
File chrome/browser/history/history_backend.h (right):

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/history/histo...
chrome/browser/history/history_backend.h:304: virtual bool GetVisitsSource(const
VisitVector& visits,
On 2011/10/21 22:44:51, sky wrote:
> Does this really need to be virtual?
> Add a description too.

Done.

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/sync/glue/typ...
File chrome/browser/sync/glue/typed_url_model_associator.cc (right):

http://codereview.chromium.org/8370011/diff/2001/chrome/browser/sync/glue/typ...
chrome/browser/sync/glue/typed_url_model_associator.cc:105: // We ignore URLs
that have never been visited by chromium (i.e. all visits
On 2011/10/22 05:37:14, timsteele wrote:
> 'all visits that were imported'?

Done.

[commit-bot: I haz the power, 2011-10-22 07:31:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/8370011/4002