Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/browsing_data_database_helper.cc

Issue 8370007: base::Bind: Convert BrowsingDatabaseHelper::StartFetching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_database_helper.cc
diff --git a/chrome/browser/browsing_data_database_helper.cc b/chrome/browser/browsing_data_database_helper.cc
index 95106aced132f3c093749ae44ef848f9137c5d99..28419ab15a5211be723a28a475b3d5915f58a33e 100644
--- a/chrome/browser/browsing_data_database_helper.cc
+++ b/chrome/browser/browsing_data_database_helper.cc
@@ -48,8 +48,7 @@ bool BrowsingDataDatabaseHelper::DatabaseInfo::IsFileSchemeData() {
}
BrowsingDataDatabaseHelper::BrowsingDataDatabaseHelper(Profile* profile)
- : completion_callback_(NULL),
- is_fetching_(false),
+ : is_fetching_(false),
tracker_(profile->GetDatabaseTracker()) {
}
@@ -57,13 +56,14 @@ BrowsingDataDatabaseHelper::~BrowsingDataDatabaseHelper() {
}
void BrowsingDataDatabaseHelper::StartFetching(
- Callback1<const std::list<DatabaseInfo>& >::Type* callback) {
+ const base::Callback<void(const std::list<DatabaseInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!is_fetching_);
- DCHECK(callback);
+ DCHECK_EQ(false, callback.is_null());
+
is_fetching_ = true;
database_info_.clear();
- completion_callback_.reset(callback);
+ completion_callback_ = callback;
BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
base::Bind(&BrowsingDataDatabaseHelper::FetchDatabaseInfoOnFileThread,
@@ -72,7 +72,7 @@ void BrowsingDataDatabaseHelper::StartFetching(
void BrowsingDataDatabaseHelper::CancelNotification() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- completion_callback_.reset(NULL);
+ completion_callback_.Reset();
}
void BrowsingDataDatabaseHelper::DeleteDatabase(const std::string& origin,
@@ -130,9 +130,9 @@ void BrowsingDataDatabaseHelper::NotifyInUIThread() {
DCHECK(is_fetching_);
// Note: completion_callback_ mutates only in the UI thread, so it's safe to
// test it here.
- if (completion_callback_ != NULL) {
- completion_callback_->Run(database_info_);
- completion_callback_.reset();
+ if (!completion_callback_.is_null()) {
+ completion_callback_.Run(database_info_);
+ completion_callback_.Reset();
}
is_fetching_ = false;
database_info_.clear();
@@ -198,12 +198,13 @@ bool CannedBrowsingDataDatabaseHelper::empty() const {
}
void CannedBrowsingDataDatabaseHelper::StartFetching(
- Callback1<const std::list<DatabaseInfo>& >::Type* callback) {
+ const base::Callback<void(const std::list<DatabaseInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!is_fetching_);
- DCHECK(callback);
+ DCHECK_EQ(false, callback.is_null());
+
is_fetching_ = true;
- completion_callback_.reset(callback);
+ completion_callback_ = callback;
BrowserThread::PostTask(
BrowserThread::WEBKIT, FROM_HERE,
base::Bind(&CannedBrowsingDataDatabaseHelper::ConvertInfoInWebKitThread,
« no previous file with comments | « chrome/browser/browsing_data_database_helper.h ('k') | chrome/browser/browsing_data_database_helper_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698