Issue 8369023: Unittest for SPDY's Failed Ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8369023: Unittest for SPDY's Failed Ping (Closed)

Created:
9 years, 2 months ago by ramant (doing other things)

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unittest for SPDY's Failed Ping. A small test to send a PING and perform CheckPingStatus immediately with hung interval of 0ms. The unit test verfies the SPDY session is closed and there are no streams. BUG=101234 R=willchan TEST=spdy network unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107032

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -3 lines)			Patch
	M	net/spdy/spdy_session.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/spdy/spdy_session_unittest.cc	View	1 2 3 4	2 chunks	+101 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

hi William, Added the unit test for not getting back a ping and closing the ...

9 years, 2 months ago (2011-10-24 18:48:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/8369023/8001

9 years, 2 months ago (2011-10-24 23:34:03 UTC) #3

Change committed as 107032

Expand Messages | Collapse Messages