Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 8369022: Declare the index as an intptr_t when the count is also an intptr_t. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc
index ef54727ac2e88c4ce8fb22681986faddd0d325ce..9a1be618eab884ab160b2025a087f5029beea9a7 100644
--- a/runtime/vm/raw_object_snapshot.cc
+++ b/runtime/vm/raw_object_snapshot.cc
@@ -313,7 +313,7 @@ RawTypeArray* TypeArray::ReadFrom(SnapshotReader* reader,
TypeArray& type_array = TypeArray::Handle(TypeArray::New(len));
reader->AddBackwardReference(object_id, &type_array);
Type& type = Type::Handle();
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
type ^= reader->ReadObject();
type_array.SetTypeAt(i, type);
}
@@ -337,7 +337,7 @@ void RawTypeArray::WriteTo(SnapshotWriter* writer,
// Write out the individual types.
intptr_t len = Smi::Value(ptr()->length_);
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
writer->WriteObject(ptr()->types_[i]);
}
}
@@ -507,7 +507,7 @@ RawTokenStream* TokenStream::ReadFrom(SnapshotReader* reader,
// Read the token stream into the TokenStream.
String& literal = String::Handle();
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
Token::Kind kind = static_cast<Token::Kind>(
Smi::Value(GetSmi(reader->Read<intptr_t>())));
literal ^= reader->ReadObject();
@@ -1032,7 +1032,7 @@ void RawOneByteString::WriteTo(SnapshotWriter* writer,
writer->Write<RawObject*>(ptr()->hash_);
// Write out the string.
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
writer->Write<uint8_t>(ptr()->data_[i]);
}
}
@@ -1050,7 +1050,7 @@ RawTwoByteString* TwoByteString::ReadFrom(SnapshotReader* reader,
// Set up the two byte string object.
TwoByteString& str_obj = TwoByteString::ZoneHandle(
TwoByteString::New(len, classes_serialized ? Heap::kOld : Heap::kNew));
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
*str_obj.CharAddr(i) = reader->Read<uint16_t>();
}
@@ -1080,7 +1080,7 @@ void RawTwoByteString::WriteTo(SnapshotWriter* writer,
writer->Write<RawObject*>(ptr()->hash_);
// Write out the string.
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
writer->Write<uint16_t>(ptr()->data_[i]);
}
}
@@ -1128,7 +1128,7 @@ void RawFourByteString::WriteTo(SnapshotWriter* writer,
writer->Write<RawObject*>(ptr()->hash_);
// Write out the string.
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
writer->Write<uint32_t>(ptr()->data_[i]);
}
}
@@ -1167,7 +1167,7 @@ static RawObject* ArrayReadFrom(SnapshotReader* reader,
result.SetTypeArguments(type_arguments);
Object& obj = Object::Handle();
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
obj = reader->ReadObject();
result.SetAt(i, obj);
}
@@ -1215,7 +1215,7 @@ static void ArrayWriteTo(SnapshotWriter* writer,
writer->WriteObject(type_arguments);
// Write out the individual objects.
- for (int i = 0; i < len; i++) {
+ for (intptr_t i = 0; i < len; i++) {
writer->WriteObject(data[i]);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698