Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 8369019: Enable installing git by default on Windows. (Closed)

Created:
9 years, 2 months ago by cmp
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Nicolas Sylvain
Visibility:
Public.

Description

Enable installing git by default on Windows. BUG=79356 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107206

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M bootstrap/win/win_tools.bat View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cmp
9 years, 2 months ago (2011-10-21 22:54:50 UTC) #1
M-A Ruel
lgtm
9 years, 2 months ago (2011-10-22 01:29:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/8369019/1
9 years, 2 months ago (2011-10-24 21:06:05 UTC) #3
commit-bot: I haz the power
Can't apply patch for file depot_tools/bootstrap/win/win_tools.bat. While running patch -p0 --forward --force; patching file depot_tools/bootstrap/win/win_tools.bat ...
9 years, 2 months ago (2011-10-24 21:06:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/8369019/5001
9 years, 2 months ago (2011-10-24 22:06:17 UTC) #5
commit-bot: I haz the power
Can't apply patch for file depot_tools/bootstrap/win/win_tools.bat. While running patch -p0 --forward --force; patching file depot_tools/bootstrap/win/win_tools.bat ...
9 years, 2 months ago (2011-10-24 22:06:18 UTC) #6
M-A Ruel
CRLF, just commit manually... Le 24 oct. 2011 18:06, <commit-bot@chromium.org> a écrit : > Can't ...
9 years, 2 months ago (2011-10-24 22:31:46 UTC) #7
cmp
9 years, 2 months ago (2011-10-25 21:11:30 UTC) #8
Testing:

1. without WIN_TOOLS_FORCE and no git.bat -> Git is installed
2. without WIN_TOOLS_FORCE and git.bat -> Git is not installed
3. with WIN_TOOLS_FORCE=1 and no git.bat -> Git is installed
4. with WIN_TOOLS_FORCE=1 and git.bat -> Git is installed

First 3 work fine, fourth doesn't.  WIN_TOOLS_FORCE is only checked if the batch
file is missing and then only causes the tool to be installed again if the
--version check fails for some reason.  So I'm going to assume the test results
look good, too, and land this locally.

Powered by Google App Engine
This is Rietveld 408576698