Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.h

Issue 8369017: ntp: remove dead code for pinning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't crash Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/ntp/most_visited_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/most_visited_handler.h
diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.h b/chrome/browser/ui/webui/ntp/most_visited_handler.h
index 22543d85aa20d372ba5cc05231a4ab68ff82148c..d34522a2654de6f12b0db3163bbef8b4c43adc74 100644
--- a/chrome/browser/ui/webui/ntp/most_visited_handler.h
+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.h
@@ -26,14 +26,10 @@ class Value;
// The handler for Javascript messages related to the "most visited" view.
//
-// This class manages two preferences:
+// This class manages one preference:
// - The URL blacklist: URLs we do not want to show in the thumbnails list. It
// is a dictionary for quick access (it associates a dummy boolean to the URL
// string).
-// - Pinned URLs: This is a dictionary for the pinned URLs for the the most
-// visited part of the new tab page. The key of the dictionary is a hash of
-// the URL and the value is a dictionary with title, url and index. This is
-// owned by the PrefService.
class MostVisitedHandler : public WebUIMessageHandler,
public content::NotificationObserver {
public:
@@ -57,12 +53,6 @@ class MostVisitedHandler : public WebUIMessageHandler,
// Callback for the "clearMostVisitedURLsBlacklist" message.
void HandleClearBlacklist(const base::ListValue* args);
- // Callback for the "addPinnedURL" message.
- void HandleAddPinnedURL(const base::ListValue* args);
-
- // Callback for the "removePinnedURL" message.
- void HandleRemovePinnedURL(const base::ListValue* args);
-
// content::NotificationObserver implementation.
virtual void Observe(int type,
const content::NotificationSource& source,
@@ -89,17 +79,9 @@ class MostVisitedHandler : public WebUIMessageHandler,
// Puts the passed URL in the blacklist (so it does not show as a thumbnail).
void BlacklistURL(const GURL& url);
- // Returns the key used in url_blacklist_ and pinned_urls_ for the passed
- // |url|.
+ // Returns the key used in url_blacklist_ for the passed |url|.
std::string GetDictionaryKeyForURL(const std::string& url);
- // Gets the page data for a pinned URL at a given index. This returns
- // true if found.
- bool GetPinnedURLAtIndex(int index, MostVisitedPage* page);
-
- void AddPinnedURL(const MostVisitedPage& page, int index);
- void RemovePinnedURL(const GURL& url);
-
// Sends pages_value_ to the javascript side to and resets page_value_.
void SendPagesValue();
« no previous file with comments | « no previous file | chrome/browser/ui/webui/ntp/most_visited_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698