Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 8369016: [ntp4] Improve horizontal mousewheel event handling for touch devices. (Closed)

Created:
9 years, 2 months ago by csilv
Modified:
9 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[ntp4] Improve horizontal mousewheel event handling for touch devices. BUG=95626 TEST=Swipe NTP4 pages, average speed swipes should only swipe a single page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106836

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : Code review simplification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M chrome/browser/resources/ntp4/card_slider.js View 1 2 3 chunks +34 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csilv
+estade for review I spent the past couple days exploring how to address this issue. ...
9 years, 2 months ago (2011-10-21 23:46:20 UTC) #1
Evan Stade
http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js File chrome/browser/resources/ntp4/card_slider.js (right): http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js#newcode252 chrome/browser/resources/ntp4/card_slider.js:252: if (this.mouseWheelCardSelected_) return; why is this necessary? don't you ...
9 years, 2 months ago (2011-10-22 00:48:35 UTC) #2
csilv
http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js File chrome/browser/resources/ntp4/card_slider.js (right): http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js#newcode252 chrome/browser/resources/ntp4/card_slider.js:252: if (this.mouseWheelCardSelected_) return; On 2011/10/22 00:48:35, Evan Stade wrote: ...
9 years, 2 months ago (2011-10-22 01:24:32 UTC) #3
csilv
http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js File chrome/browser/resources/ntp4/card_slider.js (right): http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp4/card_slider.js#newcode269 chrome/browser/resources/ntp4/card_slider.js:269: this.mouseWheelScrollAmount_ += e.wheelDeltaX; On 2011/10/22 01:24:32, csilv wrote: > ...
9 years, 2 months ago (2011-10-22 01:49:34 UTC) #4
Evan Stade
9 years, 2 months ago (2011-10-22 01:57:45 UTC) #5
great

lgtm

http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/card_slider.js (right):

http://codereview.chromium.org/8369016/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:252: if
(this.mouseWheelCardSelected_) return;
On 2011/10/22 01:24:32, csilv wrote:
> On 2011/10/22 00:48:35, Evan Stade wrote:
> > why is this necessary? don't you want it to be possible to switch through
many
> > cards with an aggressive swipe?
> 
> No.  We really want a swipe to change a single page at a time.  You can see
this
> on Android or iPhone that use page swipe UIs... no mater how aggressive it is,
> it's single page only.  If we were using touch events, this would be easy to
do.
>   But that's not an option.

ok

Powered by Google App Engine
This is Rietveld 408576698