Fix the segfault on Linux when closing a tab that is in tab fullscreen mode.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 774 matching lines @@
 #endif
 }
 
 void BrowserView::ExitFullscreen() {
   if (!IsFullscreen())
     return;  // Nothing to do.
 
 #if defined(OS_WIN)
   ProcessFullscreen(false, GURL(), FEB_TYPE_NONE);
 #else
+  fullscreen_request_.pending = false;
   // On Linux changing fullscreen is async. Ask the window to change it's
   // fullscreen state, and when done invoke ProcessFullscreen.
   frame_->SetFullscreen(false);
 #endif
 }
 
 void BrowserView::UpdateFullscreenExitBubbleContent(
     const GURL& url,
     FullscreenExitBubbleType bubble_type) {
   if (fullscreen_bubble_.get())
     fullscreen_bubble_->UpdateContent(url, bubble_type);
 }
 
 bool BrowserView::IsFullscreen() const {
   return frame_->IsFullscreen();
 }
 
 bool BrowserView::IsFullscreenBubbleVisible() const {
   return fullscreen_bubble_.get() ? true : false;
 }
 
 void BrowserView::FullScreenStateChanged() {
-  bool is_fullscreen = IsFullscreen();
-  if (is_fullscreen) {
-    DCHECK(fullscreen_request_.pending);

[yzshen1, 2011/10/21 21:45:29]

I observed fullscreen state change notification that is not caused by
Enter/ExitFullscreen() during browser shutdown. So I removed the DCHECK here.

[koz (OOO until 15th September), 2011/10/24 00:57:05]

SGTM.

-    fullscreen_request_.pending = false;
-    ProcessFullscreen(true, fullscreen_request_.url,
-                      fullscreen_request_.bubble_type);
+  if (IsFullscreen()) {
+    if (fullscreen_request_.pending) {
+      fullscreen_request_.pending = false;
+      ProcessFullscreen(true, fullscreen_request_.url,
+                        fullscreen_request_.bubble_type);
+    } else {
+      ProcessFullscreen(true, GURL(),
+                        FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION);
+    }
   } else {
     ProcessFullscreen(false, GURL(), FEB_TYPE_NONE);
   }
 }
 
 void BrowserView::RestoreFocus() {
   TabContents* selected_tab_contents = GetSelectedTabContents();
   if (selected_tab_contents)
     selected_tab_contents->view()->RestoreFocus();
 }
@@ skipping 1775 matching lines @@
   views::View::ConvertPointToScreen(GetTabContentsContainerView(), &origin);
   gfx::Rect bounds;
   bounds.set_origin(origin);
 
   AvatarMenuBubbleView* bubble_view = new AvatarMenuBubbleView(browser_.get());
   // Bubble::Show() takes ownership of the view.
   Bubble::Show(this->GetWidget(), bounds,
                views::BubbleBorder::TOP_RIGHT,
                bubble_view, bubble_view);
 }