Fix the segfault on Linux when closing a tab that is in tab fullscreen mode.

chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/gtk/rounded_window.h"
 #include "content/browser/renderer_host/render_widget_host_view.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "grit/generated_resources.h"
 #include "grit/ui_strings.h"
 #include "ui/base/gtk/gtk_floating_container.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 const GdkColor kFrameColor = GDK_COLOR_RGB(0x63, 0x63, 0x63);
 const int kMiddlePaddingPx = 30;
 }  // namespace
 
 FullscreenExitBubbleGtk::FullscreenExitBubbleGtk(
     GtkFloatingContainer* container,
     Browser* browser,
     const GURL& url,
     FullscreenExitBubbleType bubble_type)
-  : FullscreenExitBubble(browser, url, bubble_type),
-      container_(container),
-      render_widget_host_view_widget_(browser->GetSelectedTabContents()->
-          GetRenderWidgetHostView()->GetNativeView()) {
+    : FullscreenExitBubble(browser, url, bubble_type),
+      container_(container) {
   InitWidgets();
 }
 
 FullscreenExitBubbleGtk::~FullscreenExitBubbleGtk() {
 }
 
 void FullscreenExitBubbleGtk::UpdateContent(
     const GURL& url,
     FullscreenExitBubbleType bubble_type) {
   if (bubble_type == FEB_TYPE_NONE) {
@@ skipping 34 matching lines @@
   // The exit bubble is a gtk_chrome_link_button inside a gtk event box and gtk
   // alignment (these provide the background color).  This is then made rounded
   // and put into a slide widget.
 
   // The Windows code actually looks up the accelerator key in the accelerator
   // table and then converts the key to a string (in a switch statement). This
   // doesn't seem to be implemented for Gtk, so we just use F11 directly.
   std::string exit_text_utf8(l10n_util::GetStringFUTF8(
       IDS_EXIT_FULLSCREEN_MODE, l10n_util::GetStringUTF16(IDS_APP_F11_KEY)));
 
   hbox_ = gtk_hbox_new(false, ui::kControlSpacing);

[scheib, 2011/10/21 23:28:13]

What happens if you click on any other part of the bubble? E.g. the message
text, or white space? Does that take focus? Do we need to call
...set_can_focus(..., FALSE) on absolutely everything here?

[yzshen1, 2011/10/21 23:29:25]

I tried and they didn't take focus.

 
   message_label_ = gtk_label_new(GetMessage(url_).c_str());
   gtk_box_pack_start(GTK_BOX(hbox_), message_label_, FALSE, FALSE, 0);
 
   allow_button_ = gtk_button_new_with_label(
       l10n_util::GetStringUTF8(IDS_FULLSCREEN_ALLOW).c_str());
+  gtk_widget_set_can_focus(allow_button_, FALSE);
   gtk_widget_set_no_show_all(allow_button_, FALSE);
   gtk_box_pack_start(GTK_BOX(hbox_), allow_button_, FALSE, FALSE, 0);
 
   deny_button_ = gtk_button_new_with_label(
       l10n_util::GetStringUTF8(IDS_FULLSCREEN_DENY).c_str());
+  gtk_widget_set_can_focus(deny_button_, FALSE);
   gtk_widget_set_no_show_all(deny_button_, FALSE);
   gtk_box_pack_start(GTK_BOX(hbox_), deny_button_, FALSE, FALSE, 0);
 
   link_ = gtk_chrome_link_button_new(exit_text_utf8.c_str());
+  gtk_widget_set_can_focus(link_, FALSE);
   gtk_widget_set_no_show_all(link_, FALSE);
   gtk_chrome_link_button_set_use_gtk_theme(GTK_CHROME_LINK_BUTTON(link_),
                                            FALSE);
   gtk_box_pack_start(GTK_BOX(hbox_), link_, FALSE, FALSE, 0);
 
-
   instruction_label_ = gtk_label_new(UTF16ToUTF8(GetInstructionText()).c_str());
   gtk_widget_set_no_show_all(instruction_label_, FALSE);
   gtk_box_pack_start(GTK_BOX(hbox_), instruction_label_, FALSE, FALSE, 0);
 
-
   GtkWidget* bubble = gtk_util::CreateGtkBorderBin(
       hbox_, &ui::kGdkWhite,
       kPaddingPx, kPaddingPx, kPaddingPx, kPaddingPx);
   gtk_util::ActAsRoundedWindow(bubble, kFrameColor, 3,
       gtk_util::ROUNDED_ALL, gtk_util::BORDER_ALL);
   GtkWidget* alignment = gtk_alignment_new(0.0, 0.0, 1.0, 1.0);
   gtk_alignment_set_padding(GTK_ALIGNMENT(alignment), 5, 0, 0, 0);
   gtk_container_add(GTK_CONTAINER(alignment), bubble);
   ui_container_.Own(alignment);
 
@@ skipping 99 matching lines @@
   gtk_container_child_set_property(GTK_CONTAINER(floating_container),
                                    widget(), "x", &value);
 
   g_value_set_int(&value, 0);
   gtk_container_child_set_property(GTK_CONTAINER(floating_container),
                                    widget(), "y", &value);
   g_value_unset(&value);
 }
 
 void FullscreenExitBubbleGtk::OnLinkClicked(GtkWidget* link) {
-  gtk_widget_grab_focus(render_widget_host_view_widget_);
   ToggleFullscreen();
 }
 
 void FullscreenExitBubbleGtk::OnAllowClicked(GtkWidget* button) {
-  gtk_widget_grab_focus(render_widget_host_view_widget_);
   Accept();
   UpdateContent(url_, bubble_type_);
 }
 void FullscreenExitBubbleGtk::OnDenyClicked(GtkWidget* button) {
-  gtk_widget_grab_focus(render_widget_host_view_widget_);
   Cancel();
 }