Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8369012: Add a test for Instant not treating intranet paths as searches. (Closed)

Created:
9 years, 2 months ago by sreeram
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., Peter Kasting
Visibility:
Public.

Description

Add a test for Instant not treating intranet paths as searches. I've verified that the test fails without the bugfix in r105126. BUG=99836 TEST=interactive_ui_tests InstantTest.IntranetPathLooksLikeSearch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sreeram
Please review.
9 years, 2 months ago (2011-10-21 21:36:18 UTC) #1
sky
LGTM Someone must be listening to Raffi;)
9 years, 2 months ago (2011-10-21 22:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/8369012/1
9 years, 2 months ago (2011-10-22 17:39:34 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 20:17:14 UTC) #4
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 106859, job name
was 8369012-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698