Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 8369009: chromeos: Remove UpdateObserver, which has been unused for long. (Closed)

Created:
9 years, 2 months ago by satorux1
Modified:
9 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

chromeos: Remove UpdateObserver, which has been unused for long. We don't show a notification panel when an update is ready. Asked kanliu@ and he was okay with removing this. TEST=chrome and tests build. BUG=chromium-os:16564 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -201 lines) Patch
D chrome/browser/chromeos/update_browsertest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/chromeos/update_observer.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/chromeos/update_observer.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
9 years, 2 months ago (2011-10-21 22:07:39 UTC) #1
oshima
LGTM
9 years, 2 months ago (2011-10-21 22:53:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8369009/1
9 years, 2 months ago (2011-10-22 06:06:30 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-22 08:54:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8369009/1
9 years, 2 months ago (2011-10-22 17:02:51 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 19:45:09 UTC) #6
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 106859, job name
was 8369009-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698