Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 8369007: Changes launcher animations to fade before moving. (Closed)

Created:
9 years, 2 months ago by sky
Modified:
9 years, 2 months ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Changes launcher animations to fade before moving. BUG=98345 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106926

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -44 lines) Patch
M ui/aura_shell/desktop_layout_manager.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M ui/aura_shell/launcher/launcher_view.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura_shell/launcher/launcher_view.cc View 1 7 chunks +117 lines, -31 lines 1 comment Download
M views/animation/bounds_animator.h View 2 chunks +3 lines, -4 lines 0 comments Download
M views/animation/bounds_animator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 2 months ago (2011-10-21 19:49:36 UTC) #1
Ben Goodger (Google)
9 years, 2 months ago (2011-10-21 23:03:49 UTC) #2
lgtm

http://codereview.chromium.org/8369007/diff/2001/ui/aura_shell/launcher/launc...
File ui/aura_shell/launcher/launcher_view.cc (right):

http://codereview.chromium.org/8369007/diff/2001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:79: view_->layer()->ScheduleDraw();
I think the default impl of this function calls AnimationEnded by default...

Powered by Google App Engine
This is Rietveld 408576698