Issue 8369007: Changes launcher animations to fade before moving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8369007: Changes launcher animations to fade before moving. (Closed)

Created:
9 years, 2 months ago by sky

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Changes launcher animations to fade before moving. BUG=98345 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106926

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -44 lines)			Patch
M	ui/aura_shell/desktop_layout_manager.cc	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View	1	7 chunks	+117 lines, -31 lines	1 comment	Download
M	views/animation/bounds_animator.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	views/animation/bounds_animator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 2 months ago (2011-10-21 23:03:49 UTC) #2

lgtm

http://codereview.chromium.org/8369007/diff/2001/ui/aura_shell/launcher/launc...
File ui/aura_shell/launcher/launcher_view.cc (right):

http://codereview.chromium.org/8369007/diff/2001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_view.cc:79: view_->layer()->ScheduleDraw();
I think the default impl of this function calls AnimationEnded by default...

Expand Messages | Collapse Messages