Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8369006: [Aura] Support transparent webkit. (Closed)

Created:
9 years, 2 months ago by xiyuan
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

[Aura] Support transparent webkit. Support turning on webkit transparency by setting a background image. - Update RenderWidget::PaintRect to handle background transparency; - Update BackingStoreSkia::PaintToBackingStore to handle webkit transparency; - Turn on compositing of RenderWidgetHostViewAura's layer when we set a background with transparency; BUG=98311 TEST=Verify when applist change (chromium:98308) is in. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106943

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix win_aura bot #

Patch Set 3 : address brettw's comment in #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M content/browser/renderer_host/backing_store_skia.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
xiyuan
9 years, 2 months ago (2011-10-21 19:47:18 UTC) #1
xiyuan
+jam Jam, could you help to review this in case brettw does not have time?
9 years, 2 months ago (2011-10-21 20:12:46 UTC) #2
brettw
lgtm http://codereview.chromium.org/8369006/diff/1/content/browser/renderer_host/backing_store_skia.cc File content/browser/renderer_host/backing_store_skia.cc (right): http://codereview.chromium.org/8369006/diff/1/content/browser/renderer_host/backing_store_skia.cc#newcode77 content/browser/renderer_host/backing_store_skia.cc:77: canvas_.get()->drawBitmapRect(sk_bitmap, &srcrect, dstrect, &copy_paint_); In other places we ...
9 years, 2 months ago (2011-10-21 20:14:43 UTC) #3
xiyuan
Thanks for the quick review. :) http://codereview.chromium.org/8369006/diff/1/content/browser/renderer_host/backing_store_skia.cc File content/browser/renderer_host/backing_store_skia.cc (right): http://codereview.chromium.org/8369006/diff/1/content/browser/renderer_host/backing_store_skia.cc#newcode77 content/browser/renderer_host/backing_store_skia.cc:77: canvas_.get()->drawBitmapRect(sk_bitmap, &srcrect, dstrect, ...
9 years, 2 months ago (2011-10-21 20:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8369006/6001
9 years, 2 months ago (2011-10-22 05:34:49 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-22 08:32:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8369006/6001
9 years, 2 months ago (2011-10-22 15:22:22 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-22 18:03:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8369006/6001
9 years, 1 month ago (2011-10-24 16:38:34 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-10-24 17:54:21 UTC) #10
Change committed as 106943

Powered by Google App Engine
This is Rietveld 408576698