Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 8369005: Fix a bug where putting a laptop to sleep causes downloads to end normally. (Closed)

Created:
9 years, 2 months ago by ahendrickson
Modified:
9 years, 2 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., rvargas (doing something else)
Visibility:
Public.

Description

Fix a bug where putting a laptop to sleep causes downloads to end normally. Special case download interrupt reason if we get a CANCELED/ABORTED status. BUG=101044 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M content/browser/download/download_file_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/download_file_manager.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 3 chunks +21 lines, -3 lines 0 comments Download
M content/browser/download/interrupt_reasons.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahendrickson
9 years, 2 months ago (2011-10-21 19:27:09 UTC) #1
Randy Smith (Not in Mondays)
LGTM. CCing Ricardo in case he's curious, but I don't think we need his review.
9 years, 2 months ago (2011-10-21 22:38:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahendrickson@chromium.org/8369005/1
9 years, 2 months ago (2011-10-22 14:47:17 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-22 17:15:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahendrickson@chromium.org/8369005/1
9 years, 2 months ago (2011-10-24 14:51:32 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 16:52:47 UTC) #6
Change committed as 106928

Powered by Google App Engine
This is Rietveld 408576698