Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 8369003: Removing table-layout: fixed property from chrome://system page. (Closed)

Created:
9 years, 2 months ago by tbarzic
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Removing table-layout: fixed property from chrome://system page. The property causes trouble when button text is too long (like in French) TEST=Manual (with lanugage set to french). BUG=chromium-os:18471 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/about_sys.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tbarzic
9 years, 2 months ago (2011-10-21 17:56:55 UTC) #1
arv (Not doing code reviews)
Doesn't this break things? Why was table-layout: fixed in the first place?
9 years, 2 months ago (2011-10-21 18:51:14 UTC) #2
tbarzic
On 2011/10/21 18:51:14, arv wrote: > Doesn't this break things? Why was table-layout: fixed in ...
9 years, 2 months ago (2011-10-21 19:23:33 UTC) #3
arv (Not doing code reviews)
LGTM I would prefer if you can also get an LGTM from the original author ...
9 years, 2 months ago (2011-10-21 19:29:16 UTC) #4
tbarzic
9 years, 2 months ago (2011-10-21 19:38:01 UTC) #5
On 2011/10/21 19:29:16, arv wrote:
> LGTM
> 
> I would prefer if you can also get an LGTM from the original author
> (maybe that is you?)
> 
> erik
> 
> 
> 
> 
> 
> 
> 
> 
> On Fri, Oct 21, 2011 at 12:23,  <mailto:tbarzic@chromium.org> wrote:
> > On 2011/10/21 18:51:14, arv wrote:
> >>
> >> Doesn't this break things? Why was table-layout: fixed in the first place?
> >
> > I don't think it should break anything (at least I don't see anything
> > broken).
> > The only bad thing I noticed is that the first column changes its width when
> > there is a cell that has really wide lines in the third column, but that
> > doesn't
> > seem to bad.
> >
> >
> > http://codereview.chromium.org/8369003/
> >

Yes, I'm the original author :)

Powered by Google App Engine
This is Rietveld 408576698