Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6740)

Unified Diff: chrome/common/web_apps.cc

Issue 8368018: Convert chrome/common non-debug logs to debug logs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util_win.cc ('k') | chrome/common/zip.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/web_apps.cc
===================================================================
--- chrome/common/web_apps.cc (revision 107051)
+++ chrome/common/web_apps.cc (working copy)
@@ -209,7 +209,7 @@
bool ParseWebAppFromDefinitionFile(Value* definition_value,
WebApplicationInfo* web_app,
string16* error) {
- CHECK(web_app->manifest_url.is_valid());
+ DCHECK(web_app->manifest_url.is_valid());
int error_code = 0;
std::string error_message;
@@ -220,9 +220,9 @@
false, // disallow trailing comma
&error_code,
&error_message));
- CHECK(schema.get())
+ DCHECK(schema.get())
<< "Error parsing JSON schema: " << error_code << ": " << error_message;
- CHECK(schema->IsType(Value::TYPE_DICTIONARY))
+ DCHECK(schema->IsType(Value::TYPE_DICTIONARY))
<< "schema root must be dictionary.";
JSONSchemaValidator validator(static_cast<DictionaryValue*>(schema.get()));
@@ -239,7 +239,7 @@
// This must be true because the schema requires the root value to be a
// dictionary.
- CHECK(definition_value->IsType(Value::TYPE_DICTIONARY));
+ DCHECK(definition_value->IsType(Value::TYPE_DICTIONARY));
DictionaryValue* definition = static_cast<DictionaryValue*>(definition_value);
// Parse launch URL. It must be a valid URL in the same origin as the
« no previous file with comments | « chrome/common/service_process_util_win.cc ('k') | chrome/common/zip.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698