Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2816)

Unified Diff: chrome/common/logging_chrome.cc

Issue 8368018: Convert chrome/common non-debug logs to debug logs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/json_schema_validator.cc ('k') | chrome/common/mac/cfbundle_blocker.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
===================================================================
--- chrome/common/logging_chrome.cc (revision 107051)
+++ chrome/common/logging_chrome.cc (working copy)
@@ -187,15 +187,15 @@
// We don't care if the unlink fails; we're going to continue anyway.
if (::unlink(symlink_path.value().c_str()) == -1) {
if (symlink_exists) // only warn if we might expect it to succeed.
- PLOG(WARNING) << "Unable to unlink " << symlink_path.value();
+ DPLOG(WARNING) << "Unable to unlink " << symlink_path.value();
}
if (!file_util::CreateSymbolicLink(target_path, symlink_path)) {
- PLOG(ERROR) << "Unable to create symlink " << symlink_path.value()
- << " pointing at " << target_path.value();
+ DPLOG(ERROR) << "Unable to create symlink " << symlink_path.value()
+ << " pointing at " << target_path.value();
}
} else {
if (!file_util::ReadSymbolicLink(symlink_path, &target_path))
- PLOG(ERROR) << "Unable to read symlink " << symlink_path.value();
+ DPLOG(ERROR) << "Unable to read symlink " << symlink_path.value();
}
return target_path;
}
@@ -203,9 +203,9 @@
void RemoveSymlinkAndLog(const FilePath& link_path,
const FilePath& target_path) {
if (::unlink(link_path.value().c_str()) == -1)
- PLOG(WARNING) << "Unable to unlink symlink " << link_path.value();
+ DPLOG(WARNING) << "Unable to unlink symlink " << link_path.value();
if (::unlink(target_path.value().c_str()) == -1)
- PLOG(WARNING) << "Unable to unlink log file " << target_path.value();
+ DPLOG(WARNING) << "Unable to unlink log file " << target_path.value();
}
} // anonymous namespace
@@ -252,7 +252,7 @@
logging::LOCK_LOG_FILE,
logging::APPEND_TO_OLD_LOG_FILE,
dcheck_state)) {
- LOG(ERROR) << "Unable to initialize logging to " << log_path.value();
+ DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
RemoveSymlinkAndLog(log_path, target_path);
} else {
chrome_logging_redirected_ = true;
@@ -314,7 +314,7 @@
#if defined(OS_CHROMEOS)
if (!success) {
- PLOG(ERROR) << "Unable to initialize logging to " << log_path.value()
+ DPLOG(ERROR) << "Unable to initialize logging to " << log_path.value()
<< " (which should be a link to " << target_path.value() << ")";
RemoveSymlinkAndLog(log_path, target_path);
chrome_logging_failed_ = true;
@@ -322,7 +322,7 @@
}
#else
if (!success) {
- PLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
+ DPLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
chrome_logging_failed_ = true;
return;
}
@@ -357,7 +357,7 @@
level >= 0 && level < LOG_NUM_SEVERITIES) {
logging::SetMinLogLevel(level);
} else {
- LOG(WARNING) << "Bad log level: " << log_level;
+ DLOG(WARNING) << "Bad log level: " << log_level;
}
}
« no previous file with comments | « chrome/common/json_schema_validator.cc ('k') | chrome/common/mac/cfbundle_blocker.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698