Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/common/extensions/extension_permission_set.cc

Issue 8368018: Convert chrome/common non-debug logs to debug logs. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_messages.cc ('k') | chrome/common/extensions/extension_unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_permission_set.cc
===================================================================
--- chrome/common/extensions/extension_permission_set.cc (revision 106774)
+++ chrome/common/extensions/extension_permission_set.cc (working copy)
@@ -84,7 +84,7 @@
const char kWindowsPermission[] = "windows";
void AddPatternsAndRemovePaths(const URLPatternSet& set, URLPatternSet* out) {
- CHECK(out);
+ DCHECK(out);
for (URLPatternSet::const_iterator i = set.begin(); i != set.end(); ++i) {
URLPattern p = *i;
p.SetPath("/*");
@@ -102,7 +102,7 @@
ExtensionPermissionMessage ExtensionPermissionMessage::CreateFromHostList(
const std::set<std::string>& hosts) {
std::vector<std::string> host_list(hosts.begin(), hosts.end());
- CHECK_GT(host_list.size(), 0UL);
+ DCHECK_GT(host_list.size(), 0UL);
ID message_id;
string16 message;
@@ -355,8 +355,8 @@
void ExtensionPermissionsInfo::RegisterAlias(
const char* name, const char* alias) {
- CHECK(name_map_.find(name) != name_map_.end());
- CHECK(name_map_.find(alias) == name_map_.end());
+ DCHECK(name_map_.find(name) != name_map_.end());
+ DCHECK(name_map_.find(alias) == name_map_.end());
name_map_[alias] = name_map_[name];
}
@@ -366,8 +366,8 @@
int l10n_message_id,
ExtensionPermissionMessage::ID message_id,
int flags) {
- CHECK(id_map_.find(id) == id_map_.end());
- CHECK(name_map_.find(name) == name_map_.end());
+ DCHECK(id_map_.find(id) == id_map_.end());
+ DCHECK(name_map_.find(name) == name_map_.end());
ExtensionAPIPermission* permission =
new ExtensionAPIPermission(id, name, l10n_message_id, message_id, flags);
@@ -392,7 +392,7 @@
const ExtensionAPIPermissionSet& apis,
const URLPatternSet& explicit_hosts)
: apis_(apis) {
- CHECK(extension);
+ DCHECK(extension);
AddPatternsAndRemovePaths(explicit_hosts, &explicit_hosts_);
InitImplicitExtensionPermissions(extension);
InitEffectiveHosts();
« no previous file with comments | « chrome/common/extensions/extension_messages.cc ('k') | chrome/common/extensions/extension_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698