Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: chrome/browser/ui/views/location_bar/star_view.cc

Issue 8368016: Rebase BookmarkBubble on the new views bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only SelectAll on the title textfield when the buble is first shown. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/star_view.h" 5 #include "chrome/browser/ui/views/location_bar/star_view.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/command_updater.h" 9 #include "chrome/browser/command_updater.h"
10 #include "chrome/browser/ui/view_ids.h" 10 #include "chrome/browser/ui/view_ids.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 59
60 bool StarView::OnKeyPressed(const views::KeyEvent& event) { 60 bool StarView::OnKeyPressed(const views::KeyEvent& event) {
61 if (event.key_code() == ui::VKEY_SPACE || 61 if (event.key_code() == ui::VKEY_SPACE ||
62 event.key_code() == ui::VKEY_RETURN) { 62 event.key_code() == ui::VKEY_RETURN) {
63 command_updater_->ExecuteCommand(IDC_BOOKMARK_PAGE); 63 command_updater_->ExecuteCommand(IDC_BOOKMARK_PAGE);
64 return true; 64 return true;
65 } 65 }
66 return false; 66 return false;
67 } 67 }
68
69 void StarView::BubbleClosing(Bubble* bubble, bool closed_by_escape) {
70 }
71
72 bool StarView::CloseOnEscape() {
73 return true;
74 }
75
76 bool StarView::FadeInOnShow() {
77 return false;
78 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/star_view.h ('k') | chrome/browser/ui/views/toolbar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698