Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: base/command_line.cc

Issue 8368009: Replace most LOG statements with DLOG statements in base. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_paths_linux.cc ('k') | base/debug/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line.cc
===================================================================
--- base/command_line.cc (revision 106858)
+++ base/command_line.cc (working copy)
@@ -268,8 +268,8 @@
const std::string& switch_string) const {
StringType value = GetSwitchValueNative(switch_string);
if (!IsStringASCII(value)) {
- LOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII.";
- return "";
+ DLOG(WARNING) << "Value of switch (" << switch_string << ") must be ASCII.";
+ return std::string();
}
#if defined(OS_WIN)
return WideToASCII(value);
@@ -394,8 +394,8 @@
wchar_t** args = NULL;
args = ::CommandLineToArgvW(command_line_string.c_str(), &num_args);
- PLOG_IF(FATAL, !args) << "CommandLineToArgvW failed on command line: " <<
- command_line;
+ DPLOG_IF(FATAL, !args) << "CommandLineToArgvW failed on command line: "
+ << command_line;
InitFromArgv(num_args, args);
LocalFree(args);
}
« no previous file with comments | « base/base_paths_linux.cc ('k') | base/debug/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698