Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/thread_local_win.cc

Issue 8368009: Replace most LOG statements with DLOG statements in base. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/threading/thread_local_posix.cc ('K') | « base/threading/thread_local_posix.cc ('k') | base/tracked_objects.cc » ('j') | base/tracked_objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread_local_win.cc
===================================================================
--- base/threading/thread_local_win.cc (revision 106774)
+++ base/threading/thread_local_win.cc (working copy)
@@ -15,7 +15,7 @@
// static
void ThreadLocalPlatform::AllocateSlot(SlotType& slot) {
slot = TlsAlloc();
- CHECK_NE(slot, TLS_OUT_OF_INDEXES);
+ DCHECK_NE(slot, TLS_OUT_OF_INDEXES);
jar (doing other things) 2011/10/23 00:36:28 Again... I think we should stay with CHECK here.
}
// static
@@ -33,7 +33,7 @@
// static
void ThreadLocalPlatform::SetValueInSlot(SlotType& slot, void* value) {
if (!TlsSetValue(slot, value)) {
- LOG(FATAL) << "Failed to TlsSetValue().";
+ DLOG(FATAL) << "Failed to TlsSetValue().";
jar (doing other things) 2011/10/23 00:36:28 This is fine IMO (as mentioned in posix file).
}
}
« base/threading/thread_local_posix.cc ('K') | « base/threading/thread_local_posix.cc ('k') | base/tracked_objects.cc » ('j') | base/tracked_objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698