Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3091)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/non_thread_safe_unittest.cc

Issue 8368009: Replace most LOG statements with DLOG statements in base. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/test_timeouts.cc ('K') | « base/test/test_timeouts.cc ('k') | base/threading/platform_thread_mac.mm » ('j') | base/threading/thread_local_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/non_thread_safe_unittest.cc
===================================================================
--- base/threading/non_thread_safe_unittest.cc (revision 106774)
+++ base/threading/non_thread_safe_unittest.cc (working copy)
@@ -20,7 +20,7 @@
// Verifies that it was called on the same thread as the constructor.
void DoStuff() {
- CHECK(CalledOnValidThread());
+ DCHECK(CalledOnValidThread());
jar (doing other things) 2011/10/23 00:36:28 Better would be ASSERT, since this is a test file.
}
void DetachFromThread() {
« base/test/test_timeouts.cc ('K') | « base/test/test_timeouts.cc ('k') | base/threading/platform_thread_mac.mm » ('j') | base/threading/thread_local_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698