base/test/test_timeouts.cc - Issue 8368009: Replace most LOG statements with DLOG statements in base.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/test_timeouts.cc

Issue 8368009: Replace most LOG statements with DLOG statements in base. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/test/test_timeouts.h"	5 #include "base/test/test_timeouts.h"

6	6

7 #include "base/command_line.h"	7 #include "base/command_line.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/string_number_conversions.h"	9 #include "base/string_number_conversions.h"

10 #include "base/test/test_switches.h"	10 #include "base/test/test_switches.h"

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 // per the CHECKS below.	59 // per the CHECKS below.

60 InitializeTimeout(switches::kTestTinyTimeout, &tiny_timeout_ms_);	60 InitializeTimeout(switches::kTestTinyTimeout, &tiny_timeout_ms_);

61 InitializeTimeout(switches::kUiTestActionTimeout, tiny_timeout_ms_,	61 InitializeTimeout(switches::kUiTestActionTimeout, tiny_timeout_ms_,

62 &action_timeout_ms_);	62 &action_timeout_ms_);

63 InitializeTimeout(switches::kUiTestActionMaxTimeout, action_timeout_ms_,	63 InitializeTimeout(switches::kUiTestActionMaxTimeout, action_timeout_ms_,

64 &action_max_timeout_ms_);	64 &action_max_timeout_ms_);

65 InitializeTimeout(switches::kTestLargeTimeout, action_max_timeout_ms_,	65 InitializeTimeout(switches::kTestLargeTimeout, action_max_timeout_ms_,

66 &large_test_timeout_ms_);	66 &large_test_timeout_ms_);

67	67

68 // The timeout values should be increasing in the right order.	68 // The timeout values should be increasing in the right order.

69 CHECK(tiny_timeout_ms_ <= action_timeout_ms_);	69 DCHECK(tiny_timeout_ms_ <= action_timeout_ms_);
	jar (doing other things) 2011/10/23 00:36:28 Is this actually test code, where an ASSERT... wou Is this actually test code, where an ASSERT... would be better?
70 CHECK(action_timeout_ms_ <= action_max_timeout_ms_);	70 DCHECK(action_timeout_ms_ <= action_max_timeout_ms_);

71 CHECK(action_max_timeout_ms_ <= large_test_timeout_ms_);	71 DCHECK(action_max_timeout_ms_ <= large_test_timeout_ms_);

72 }	72 }

OLD	NEW