Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: views/examples/bubble_example.cc

Issue 8368006: Support Windows native textfield, combobox, etc. in new bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/examples/bubble_example.cc
diff --git a/views/examples/bubble_example.cc b/views/examples/bubble_example.cc
index f99155b2da58b8dc8b65fb5812aefef1833e8e64..43bd46c4ecea407437a58af22222cc2de40e5607 100644
--- a/views/examples/bubble_example.cc
+++ b/views/examples/bubble_example.cc
@@ -90,11 +90,12 @@ void BubbleExample::ButtonPressed(views::Button* sender,
new ExampleBubbleDelegateView(config);
views::Widget* bubble = views::BubbleDelegateView::CreateBubble(
bubble_delegate, example_view()->GetWidget());
+ DCHECK(bubble);
Ben Goodger (Google) 2011/10/31 17:43:02 Looking at your code, CreateBubble can never retur
msw 2011/10/31 17:47:37 To silence a clang error for the otherwise unused
Ben Goodger (Google) 2011/10/31 17:48:29 Why not nix the variable then?
msw 2011/10/31 17:56:33 Done. I thought it might help fill out the example
if (config.fade_in)
bubble_delegate->StartFade(true);
else
- bubble->Show();
+ bubble_delegate->Show();
if (config.fade_out) {
bubble_delegate->set_close_on_esc(false);

Powered by Google App Engine
This is Rietveld 408576698