Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: views/bubble/bubble_delegate_unittest.cc

Issue 8368006: Support Windows native textfield, combobox, etc. in new bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and merge. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/bubble/bubble_delegate_unittest.cc
diff --git a/views/bubble/bubble_delegate_unittest.cc b/views/bubble/bubble_delegate_unittest.cc
index ea3241c2f1938762f074afa64d396f074ca90e96..eb0183a190f9cc0370ef40ca75fb0cff74f6efe1 100644
--- a/views/bubble/bubble_delegate_unittest.cc
+++ b/views/bubble/bubble_delegate_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "views/bubble/bubble_delegate.h"
+#include "views/bubble/bubble_frame_view.h"
#include "views/test/views_test_base.h"
#include "views/widget/widget.h"
@@ -15,7 +16,7 @@ typedef ViewsTestBase BubbleDelegateTest;
TEST_F(BubbleDelegateTest, CreateDelegate) {
BubbleDelegateView* bubble_delegate = new BubbleDelegateView();
scoped_ptr<Widget> bubble_widget(
- views::BubbleDelegateView::CreateBubble(bubble_delegate, NULL));
+ BubbleDelegateView::CreateBubble(bubble_delegate, NULL));
EXPECT_EQ(bubble_delegate, bubble_widget->widget_delegate());
EXPECT_EQ(bubble_widget, bubble_delegate->GetWidget());
bubble_widget->CloseNow();
@@ -25,4 +26,17 @@ TEST_F(BubbleDelegateTest, CreateDelegate) {
} // namespace
+TEST_F(BubbleDelegateTest, CreateArrowBubble) {
+ BubbleDelegateView* bubble_delegate = new BubbleDelegateView();
+ scoped_ptr<Widget> bubble_widget(
+ BubbleDelegateView::CreateBubble(bubble_delegate, NULL));
+
+ BubbleBorder* border = static_cast<BubbleBorder*>(
+ bubble_delegate->GetBubbleFrameView()->border());
+ EXPECT_EQ(bubble_delegate->GetArrowLocation(), border->arrow_location());
alicet1 2011/10/31 18:48:31 this tests one more line than the one above, I thi
msw 2011/10/31 19:31:17 Done.
+ bubble_widget->CloseNow();
+ bubble_widget.reset();
+ RunPendingMessages();
+}
+
} // namespace views

Powered by Google App Engine
This is Rietveld 408576698