Issue 8368003: Make AddTraceEventETW duplicate its name argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8368003: Make AddTraceEventETW duplicate its name argument. (Closed)

Created:
9 years, 2 months ago by nduca

Modified:
9 years, 2 months ago

Reviewers:
jbates

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Make AddTraceEventETW duplicate its name argument. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106870

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/debug/trace_event.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

jbates

LGTM - for historical purposes: this is because the WebKit-side API just takes const char* ...

9 years, 2 months ago (2011-10-21 19:44:33 UTC) #2

nduca

9 years, 2 months ago (2011-10-23 03:09:47 UTC) #3

Try jobs are flake. I am going to land with --tbr because the base:: change is
trivial.