Make the placement-new buffer in LazyInstance<Type> aligned.

base/lazy_instance.h

Index: base/lazy_instance.h
===================================================================
--- base/lazy_instance.h	(revision 106713)
+++ base/lazy_instance.h	(working copy)
@@ -41,6 +41,7 @@
 #include "base/atomicops.h"
 #include "base/base_export.h"
 #include "base/basictypes.h"
+#include "base/logging.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/thread_restrictions.h"
 
@@ -51,6 +52,8 @@
   static const bool kAllowedToAccessOnNonjoinableThread = false;
 
   static Type* New(void* instance) {
+    DCHECK_EQ(reinterpret_cast<uintptr_t>(instance) % sizeof(instance), 0u)

[Nico, 2011/10/21 16:26:22]

do you need this cast?

[Timur Iskhodzhanov, 2011/10/21 16:40:28]

void * ptr;
ptr % const -> doesn't compile.

Suggestions are welcome, I don't like reinterpret_cast myself

+        << ": Bad boy, the buffer is not aligned!";

[Nico, 2011/10/21 16:26:22]

Maybe explain why this is important and what to do when this dcheck hits

[Timur Iskhodzhanov, 2011/10/21 16:40:28]

Why - Done.
What to do -> it shouldn't happen unless someone changes the LazyInstance impl.
In this case I expect one to be experienced enough to read stacktraces :)

On 2011/10/21 16:26:22, Nico wrote:

     // Use placement new to initialize our instance in our preallocated space.
     // The parenthesis is very important here to force POD type initialization.
     return new (instance) Type();
@@ -186,8 +189,8 @@
     base::subtle::Release_Store(&me->state_, STATE_EMPTY);
   }
 
+  Type *instance_;
   int8 buf_[sizeof(Type)];  // Preallocate the space for the Type instance.
-  Type *instance_;
 
   DISALLOW_COPY_AND_ASSIGN(LazyInstance);
 };