Issue 8366036: Handlify call cases for pre-monomorphic, normal, and miss.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8366036: Handlify call cases for pre-monomorphic, normal, and miss. (Closed)

Created:
9 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handlify call cases for pre-monomorphic, normal, and miss. These cases turn out to be easy. There is a lingering raw pointer implementation of TryCompileCallMiss because it's need by some of the unconverted call stubs. R=ulan@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9749

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -102 lines)			Patch
M	src/arm/ic-arm.cc	View	3 chunks	+2 lines, -13 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	src/ic.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	3 chunks	+2 lines, -13 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/stub-cache.cc	View	4 chunks	+25 lines, -38 lines	1 comment	Download
M	src/x64/ic-x64.cc	View	3 chunks	+2 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

9 years, 2 months ago (2011-10-21 11:24:42 UTC) #2

LGTM.

http://codereview.chromium.org/8366036/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):

http://codereview.chromium.org/8366036/diff/1/src/stub-cache.cc#newcode1525
src/stub-cache.cc:1525: Handle<Code> StubCompiler::CompileCallMiss(Code::Flags
flags) {
Maybe add a comment that any change in this function must be replicated in the
raw pointer version and vice versa.

Expand Messages | Collapse Messages