Adds browser-side component of Java Bridge for a TabContents

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 192 matching lines @@
           static_cast<int>(WebKit::WebView::maxTextSizeMultiplier * 100)),
       temporary_zoom_settings_(false),
       content_restrictions_(0) {
 
   render_manager_.Init(browser_context, site_instance, routing_id);
 
   // We have the initial size of the view be based on the size of the passed in
   // tab contents (normally a tab from the same window).
   view_->CreateView(base_tab_contents ?
       base_tab_contents->view()->GetContainerSize() : gfx::Size());
+
+  java_bridge_dispatcher_host_manager_.reset(

[jam, 2011/10/21 16:18:21]

we don't need to add this for all of chrome, do we? i.e. it seems we don't need
to link this in unless a port is using this java feature

[Steve Block, 2011/10/21 16:27:48]

No, this isn't needed unless we want to use the Java Bridge. I was going to ask
about this.

What's the accepted practice regarding flags? The complete feature will only
build on platforms with a JVM present, so we'll need a compile-time flag. Should
I add a run-time flag too? If so, I guess it makes sense to guard as little as
possible with the compile-time flag, and use the run-time flag where possible?

+      new JavaBridgeDispatcherHostManager(this));
 }
 
 TabContents::~TabContents() {
   is_being_destroyed_ = true;
 
   // Clear out any JavaScript state.
   if (dialog_creator_)
     dialog_creator_->ResetJavaScriptState(this);
 
   NotifyDisconnected();
@@ skipping 1241 matching lines @@
   SetIsLoading(false, NULL);
   NotifyDisconnected();
   SetIsCrashed(status, error_code);
   view()->OnTabCrashed(crashed_status(), crashed_error_code());
 
   FOR_EACH_OBSERVER(TabContentsObserver, observers_, RenderViewGone());
 }
 
 void TabContents::RenderViewDeleted(RenderViewHost* rvh) {
   render_manager_.RenderViewDeleted(rvh);
+  FOR_EACH_OBSERVER(TabContentsObserver, observers_, RenderViewDeleted(rvh));
 }
 
 void TabContents::DidNavigate(RenderViewHost* rvh,
                               const ViewHostMsg_FrameNavigate_Params& params) {
   if (content::PageTransitionIsMainFrame(params.transition))
     render_manager_.DidNavigateMainFrame(rvh);
 
   // Update the site of the SiteInstance if it doesn't have one yet.
   if (!GetSiteInstance()->has_site())
     GetSiteInstance()->SetSite(params.url);
@@ skipping 510 matching lines @@
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }
 
 bool TabContents::GotResponseToLockMouseRequest(bool allowed) {
   return render_view_host() ?
       render_view_host()->GotResponseToLockMouseRequest(allowed) : false;
 }