Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: content/renderer/render_view_impl.cc

Issue 8366032: Fix fullscreen API event delivery to be delayed until the state change has (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 106466)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -1651,25 +1651,14 @@
Send(new ViewHostMsg_ContextMenu(routing_id_, params));
}
-bool RenderViewImpl::supportsFullscreen() {
- return CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableVideoFullscreen);
-}
-
-void RenderViewImpl::enterFullscreenForNode(const WebKit::WebNode& node) {
- NOTIMPLEMENTED();
-}
-
-void RenderViewImpl::exitFullscreenForNode(const WebKit::WebNode& node) {
- NOTIMPLEMENTED();
-}
-
void RenderViewImpl::enterFullscreen() {
- Send(new ViewHostMsg_ToggleFullscreen(routing_id_, true));
+ // TODO(darin): Remove once WebKit roll is complete.
+ enterFullScreen();
}
void RenderViewImpl::exitFullscreen() {
- Send(new ViewHostMsg_ToggleFullscreen(routing_id_, false));
+ // TODO(darin): Remove once WebKit roll is complete.
+ exitFullScreen();
}
void RenderViewImpl::setStatusText(const WebString& text) {
@@ -1860,6 +1849,15 @@
SendAndRunNestedMessageLoop(new ViewHostMsg_RunModal(routing_id_));
}
+bool RenderViewImpl::enterFullScreen() {
+ Send(new ViewHostMsg_ToggleFullscreen(routing_id_, true));
+ return true;
+}
+
+void RenderViewImpl::exitFullScreen() {
+ Send(new ViewHostMsg_ToggleFullscreen(routing_id_, false));
+}
+
// WebKit::WebFrameClient -----------------------------------------------------
WebPlugin* RenderViewImpl::createPlugin(WebFrame* frame,
@@ -3568,7 +3566,10 @@
}
void RenderViewImpl::OnExitFullscreen() {
+ // TODO(darin): Remove this IPC once WebKit has been updated.
+#ifndef WEBKIT_HAS_NEW_FULLSCREEN_API
webview()->exitFullscreen();
+#endif
}
void RenderViewImpl::OnSetPageEncoding(const std::string& encoding_name) {
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698