Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker.h

Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For try jobs. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/browser_thread_model_worker.h
diff --git a/chrome/browser/sync/glue/browser_thread_model_worker.h b/chrome/browser/sync/glue/browser_thread_model_worker.h
index c1c0730795d5368ded4f33abe75c6864393f6aef..487e56cddb344de69793098c307655f29d2791bc 100644
--- a/chrome/browser/sync/glue/browser_thread_model_worker.h
+++ b/chrome/browser/sync/glue/browser_thread_model_worker.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "chrome/browser/sync/engine/model_safe_worker.h"
+#include "chrome/browser/sync/util/unrecoverable_error_info.h"
#include "content/browser/browser_thread.h"
namespace base {
@@ -27,15 +28,18 @@ class BrowserThreadModelWorker : public browser_sync::ModelSafeWorker {
virtual ~BrowserThreadModelWorker();
// ModelSafeWorker implementation. Called on the sync thread.
- virtual void DoWorkAndWaitUntilDone(Callback0::Type* work);
- virtual ModelSafeGroup GetModelSafeGroup();
+ virtual UnrecoverableErrorInfo DoWorkAndWaitUntilDone(
+ const WorkCallback& work) OVERRIDE;
+ virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE;
protected:
// Marked pure virtual so subclasses have to override, but there is
// an implementation that subclasses should use. This is so that
// (subclass)::CallDoWorkAndSignalTask shows up in callstacks.
virtual void CallDoWorkAndSignalTask(
- Callback0::Type* work, base::WaitableEvent* done) = 0;
+ const WorkCallback& work,
+ base::WaitableEvent* done,
+ UnrecoverableErrorInfo* error_info) = 0;
private:
BrowserThread::ID thread_;
@@ -54,7 +58,9 @@ class DatabaseModelWorker : public BrowserThreadModelWorker {
protected:
virtual void CallDoWorkAndSignalTask(
- Callback0::Type* work, base::WaitableEvent* done) OVERRIDE;
+ const WorkCallback& work,
+ base::WaitableEvent* done,
+ UnrecoverableErrorInfo* error_info) OVERRIDE;
};
class FileModelWorker : public BrowserThreadModelWorker {
@@ -64,7 +70,9 @@ class FileModelWorker : public BrowserThreadModelWorker {
protected:
virtual void CallDoWorkAndSignalTask(
- Callback0::Type* work, base::WaitableEvent* done) OVERRIDE;
+ const WorkCallback& work,
+ base::WaitableEvent* done,
+ UnrecoverableErrorInfo* error_info) OVERRIDE;
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/model_safe_worker.cc ('k') | chrome/browser/sync/glue/browser_thread_model_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698