Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/sync/engine/model_changing_syncer_command.h

Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For try jobs. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/model_changing_syncer_command.h
diff --git a/chrome/browser/sync/engine/model_changing_syncer_command.h b/chrome/browser/sync/engine/model_changing_syncer_command.h
index f6d6a436ac7e22966609258a08681b3f0a7df171..23aeec88b0db6426478798ab97c6621335f65555 100644
--- a/chrome/browser/sync/engine/model_changing_syncer_command.h
+++ b/chrome/browser/sync/engine/model_changing_syncer_command.h
@@ -7,6 +7,7 @@
#pragma once
#include "chrome/browser/sync/engine/syncer_command.h"
+#include "chrome/browser/sync/util/unrecoverable_error_info.h"
namespace browser_sync {
namespace sessions {
@@ -32,8 +33,11 @@ class ModelChangingSyncerCommand : public SyncerCommand {
virtual void ExecuteImpl(sessions::SyncSession* session);
// wrapper so implementations don't worry about storing work_session
- void StartChangingModel() {
+ UnrecoverableErrorInfo StartChangingModel() {
+ // TODO(lipalani): |ModelChangingExecuteImpl| should return an
+ // UnrecoverableErrorInfo struct.
ModelChangingExecuteImpl(work_session_);
+ return UnrecoverableErrorInfo();
}
// Sometimes, a command has work to do that needs to touch global state
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698