chrome/browser/sync/engine/syncer_util.h - Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/syncer_util.h

Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: For a high level review. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/model_changing_syncer_command.cc ('K') | « chrome/browser/sync/engine/syncer_types.cc ('k') | chrome/browser/sync/engine/syncer_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/syncer_util.h

diff --git a/chrome/browser/sync/engine/syncer_util.h b/chrome/browser/sync/engine/syncer_util.h

index e500e6cfaf48aa824d1316578fe5b9451a05d097..fd9d8640807f2a3299e87fb64d613079a8a0c131 100644

--- a/chrome/browser/sync/engine/syncer_util.h

+++ b/chrome/browser/sync/engine/syncer_util.h

@@ -76,7 +76,7 @@ class SyncerUtil {

// This function is called on an entry when we can update the user-facing data

// from the server data.

- static void UpdateLocalDataFromServerData(syncable::WriteTransaction* trans,

+ static bool UpdateLocalDataFromServerData(syncable::WriteTransaction* trans,

syncable::MutableEntry* entry);

static VerifyCommitResult ValidateCommitEntry(syncable::Entry* entry);