Introduce the plumbing necessary to report Unrecoverable error from model safe workers.

chrome/browser/sync/engine/model_changing_syncer_command.h

Index: chrome/browser/sync/engine/model_changing_syncer_command.h
diff --git a/chrome/browser/sync/engine/model_changing_syncer_command.h b/chrome/browser/sync/engine/model_changing_syncer_command.h
index f6d6a436ac7e22966609258a08681b3f0a7df171..d7404c6b0a1fe8f42a4f5f98788e27e4ca08252f 100644
--- a/chrome/browser/sync/engine/model_changing_syncer_command.h
+++ b/chrome/browser/sync/engine/model_changing_syncer_command.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include "chrome/browser/sync/engine/syncer_command.h"
+#include "chrome/browser/sync/sessions/unrecoverable_error_info.h"
 
 namespace browser_sync {
 namespace sessions {
@@ -32,7 +33,8 @@ class ModelChangingSyncerCommand : public SyncerCommand {
   virtual void ExecuteImpl(sessions::SyncSession* session);
 
   // wrapper so implementations don't worry about storing work_session
-  void StartChangingModel() {
+  void StartChangingModel(sessions::UnrecoverableErrorInfo* error_info) {

[akalin, 2011/10/25 03:20:06]

if you're going to change this, this should return the struct directly, and
callers should explicitly ignore_result() and have a TODO.

Or you could leave this as is and ignore_result() the return value of
ModelChangingExecuteImpl.

[akalin, 2011/10/25 03:29:41]

Sorry, I got confused.  This is the function that gets posted.  But it should
return the struct directly anyway.

[lipalani1, 2011/10/26 00:12:13]

I dont want to change this internally just yet. Let me know what you think.
On 2011/10/25 03:29:41, akalin wrote:
Done.

[lipalani1, 2011/10/26 00:12:13]

Done.

+    // TODO(lipalani): Pass in error_info parameter to this function.

[akalin, 2011/10/25 03:29:41]

The TODO should read: Change ModelChangingExecuteImpl to return an
UnrecoverableErrorInfo struct.

[lipalani1, 2011/10/26 00:12:13]

Done.

     ModelChangingExecuteImpl(work_session_);
   }