Issue 8366016: Split out bluetooth UI handler from system UI handler.

Issue 8366016: Split out bluetooth UI handler from system UI handler. (Closed)

Created:
9 years, 2 months ago by kevers

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), Rick Byers, Vince Laviano

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Split out bluetooth UI handler from system UI handler. BUG=Work in progress towards fixing chromium:100392. TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106917

Patch Set 2 : Merge with trunk. #

Patch Set 3 : Add Bluetooth UI handler. #

Total comments: 1

Patch Set 4 : Remove blank line and unused import. #

Patch Set 5 : Merge with trunk #

Patch Set 6 : Merge with trunk #

Patch Set 7 : Merge with trunk #

Patch Set 8 : Merge with trunk. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -96 lines)			Patch
A	chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h	View	1 2 3	1 chunk	+59 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc	View	1 2 3	1 chunk	+129 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_options_handler.h	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_options_handler.cc	View	1	4 chunks	+0 lines, -76 lines	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevers

Hi James, Can you please have a look at this CL. In anticipation of requiring ...

9 years, 2 months ago (2011-10-20 21:15:49 UTC) #1

James Hawkins

LGTM with nit. http://codereview.chromium.org/8366016/diff/4003/chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h (right): http://codereview.chromium.org/8366016/diff/4003/chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h#newcode26 chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h:26: Consistency: remove blank line.

9 years, 2 months ago (2011-10-20 21:24:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/8366016/2010

9 years, 2 months ago (2011-10-21 14:34:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/8366016/11001

9 years, 2 months ago (2011-10-24 12:38:21 UTC) #4

commit-bot: I haz the power

9 years, 2 months ago (2011-10-24 13:41:00 UTC) #5

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 106908, job name
was 8366016-11001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

Expand Messages | Collapse Messages