Use system_request_context in TranslateManager instead of Profile::GetDefaultRequestContext.

Use system_request_context in TranslateManager instead of Profile::GetDefaultRequestContext.

BUG=89396
TEST=The translate features work as usual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107706

[Joao da Silva, 2011-10-21 15:31:33]

Profile::GetDefaultRequestContext has been deprecated, and should be replaced.
The TranslateManager has 2 such uses, introduced in these CLs:

http://codereview.chromium.org/552216/ (translate_service.cc)
http://codereview.chromium.org/7171002

Adding @mad and @jcivelli as reviewers, since you're the authors of those CLs.

As far as I can see, there's nothing profile-specific in these requests to
translate.google.com, and the system request context can be used. It also has
the advantage that whatever is fetched can be cached and reused across profiles
this way.

I see a potential problem with URLRequestContext::accept_language; does the
Accept-Language header make a difference in the requests from the translate
manager to translate.google.com?

[Joao da Silva, 2011-10-25 15:12:57]

Friendly ping

[MAD, 2011-10-27 03:11:28]

LGTM...

Sorry about the delay, was partly offline last week...

Thanks for the fix!

BYE
MAD

[commit-bot: I haz the power, 2011-10-28 08:59:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8365033/1

[commit-bot: I haz the power, 2011-10-28 08:59:44]

Can't apply patch for file chrome/browser/translate/translate_manager.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/translate/translate_manager.cc
Hunk #1 FAILED at 758.
Hunk #2 FAILED at 775.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/translate/translate_manager.cc.rej

[commit-bot: I haz the power, 2011-10-28 09:08:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8365033/7001

[commit-bot: I haz the power, 2011-10-28 10:08:18]

Change committed as 107706