Issue 8365020: Update Panel titlebar text and icon layout when resized on Mac.

Issue 8365020: Update Panel titlebar text and icon layout when resized on Mac. (Closed)

Created:
9 years, 2 months ago by dcheng

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Dmitry Titov, jianli

CC:
chromium-reviews, jennb, jianli, prasadt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update Panel titlebar text and icon layout when resized on Mac. BUG=100831 TEST=attached test case on bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106839

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -6 lines)			Patch
M	chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download

Total messages: 9 (0 generated)

Dmitry Titov

Great! Is it possible to create a simple test for that?

9 years, 2 months ago (2011-10-21 01:05:42 UTC) #2

dcheng

On 2011/10/21 01:05:42, Dmitry Titov wrote: > Great! > > Is it possible to create ...

9 years, 2 months ago (2011-10-21 01:39:20 UTC) #3

jennb

Drive by... Maybe add something generic to NativePanelTesting to verify titlebar? On Thu, Oct 20, ...

9 years, 2 months ago (2011-10-21 17:21:04 UTC) #4

Dmitry Titov

Right. Something like NativePanelTesting::VerifyTitlebarLayout() that would go all the way through controller to titlebar and ...

9 years, 2 months ago (2011-10-21 17:57:41 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8365020/6002

9 years, 2 months ago (2011-10-21 22:54:16 UTC) #8

Change committed as 106839