Issue 8365017: Convert the flash clipboard API to thunk system.

Issue 8365017: Convert the flash clipboard API to thunk system. (Closed)

Created:
9 years, 2 months ago by brettw

Modified:
9 years, 2 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Convert the flash clipboard API to thunk system. This adds a new clipboard API and thunks for it, and converts the existing proxy to use the new system. This adds a UI test for this feature. BUG= TEST=included Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106857

Patch Set 1 #

Total comments: 6

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+325 lines, -122 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	ppapi/ppapi_tests.gypi	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	ppapi/proxy/interface_list.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_flash_clipboard_proxy.h	View	2 chunks	+22 lines, -10 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_clipboard_proxy.cc	View	3 chunks	+66 lines, -72 lines	1 comment	Download
M	ppapi/shared_impl/function_group_base.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/tests/test_flash_clipboard.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	ppapi/tests/test_flash_clipboard.cc	View	1 chunk	+44 lines, -0 lines	1 comment	Download
M	ppapi/tests/test_flash_fullscreen.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	ppapi/thunk/ppb_flash_clipboard_api.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	ppapi/thunk/ppb_flash_clipboard_thunk.cc	View	1 chunk	+57 lines, -0 lines	2 comments	Download
M	ppapi/thunk/thunk.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_clipboard_impl.h	View	1 chunk	+31 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_clipboard_impl.cc	View	2 chunks	+25 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with a few small changes. http://codereview.chromium.org/8365017/diff/1/ppapi/ppapi_shared.gypi File ppapi/ppapi_shared.gypi (right): http://codereview.chromium.org/8365017/diff/1/ppapi/ppapi_shared.gypi#newcode125 ppapi/ppapi_shared.gypi:125: 'thunk/ppb_flash_clipboard_api.h', Nit: alphabetical ...

9 years, 2 months ago (2011-10-20 23:41:00 UTC) #2

brettw

9 years, 2 months ago (2011-10-21 20:09:03 UTC) #3

http://codereview.chromium.org/8365017/diff/1/ppapi/thunk/ppb_flash_clipboard...
File ppapi/thunk/ppb_flash_clipboard_thunk.cc (right):

http://codereview.chromium.org/8365017/diff/1/ppapi/thunk/ppb_flash_clipboard...
ppapi/thunk/ppb_flash_clipboard_thunk.cc:40: return PP_ERROR_NOINTERFACE;
On 2011/10/20 23:41:01, viettrungluu wrote:
> Is PP_ERROR_NOINTERFACE really correct here?

It seems as correct as "general error". The happens when interface is internally
not hooked up.

Expand Messages | Collapse Messages