Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: patches/to_upstream/44_vorbis_oob_read.patch

Issue 8365014: Avoid the possibility to read out-of-bounds of a static global array in Vorbis (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « patches/README ('k') | source/patched-ffmpeg/libavcodec/vorbis.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: patches/to_upstream/44_vorbis_oob_read.patch
===================================================================
--- patches/to_upstream/44_vorbis_oob_read.patch (revision 0)
+++ patches/to_upstream/44_vorbis_oob_read.patch (revision 0)
@@ -0,0 +1,21 @@
+diff -wurp -N orig/libavcodec/vorbis.c patched-ffmpeg/libavcodec/vorbis.c
+--- orig/libavcodec/vorbis.c 2011-10-20 15:33:53.446580551 -0700
++++ patched-ffmpeg/libavcodec/vorbis.c 2011-10-20 15:34:15.605319551 -0700
+@@ -150,7 +150,7 @@ void ff_vorbis_ready_floor1_list(vorbis_
+ }
+ }
+
+-static inline void render_line_unrolled(intptr_t x, intptr_t y, int x1,
++static inline void render_line_unrolled(intptr_t x, unsigned char y, int x1,
+ intptr_t sy, int ady, int adx,
+ float *buf)
+ {
+@@ -185,7 +185,7 @@ static void render_line(int x0, int y0,
+ } else {
+ int base = dy / adx;
+ int x = x0;
+- int y = y0;
++ unsigned char y = y0;
+ int err = -adx;
+ ady -= FFABS(base) * adx;
+ while (++x < x1) {
« no previous file with comments | « patches/README ('k') | source/patched-ffmpeg/libavcodec/vorbis.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698