Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ppapi/proxy/ppb_file_ref_proxy.h

Issue 8364040: Revert 106677 (caused several PPAPI test timeouts, see http://crbug.com/101154) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/ppb_file_ref_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_file_ref_proxy.h
===================================================================
--- ppapi/proxy/ppb_file_ref_proxy.h (revision 106716)
+++ ppapi/proxy/ppb_file_ref_proxy.h (working copy)
@@ -11,9 +11,7 @@
#include "ppapi/c/pp_module.h"
#include "ppapi/c/pp_resource.h"
#include "ppapi/c/pp_time.h"
-#include "ppapi/cpp/completion_callback.h"
#include "ppapi/proxy/interface_proxy.h"
-#include "ppapi/proxy/proxy_non_thread_safe_ref_count.h"
struct PPB_FileRef_Dev;
@@ -61,36 +59,24 @@
private:
// Message handlers.
- void OnMsgCreate(const HostResource& file_system,
+ void OnMsgCreate(const ppapi::HostResource& file_system,
const std::string& path,
PPB_FileRef_CreateInfo* result);
- void OnMsgGetParent(const HostResource& host_resource,
+ void OnMsgGetParent(const ppapi::HostResource& host_resource,
PPB_FileRef_CreateInfo* result);
- void OnMsgMakeDirectory(const HostResource& host_resource,
+ void OnMsgMakeDirectory(const ppapi::HostResource& host_resource,
PP_Bool make_ancestors,
- int callback_id);
- void OnMsgTouch(const HostResource& host_resource,
+ uint32_t serialized_callback);
+ void OnMsgTouch(const ppapi::HostResource& host_resource,
PP_Time last_access,
PP_Time last_modified,
- int callback_id);
- void OnMsgDelete(const HostResource& host_resource,
- int callback_id);
- void OnMsgRename(const HostResource& file_ref,
- const HostResource& new_file_ref,
- int callback_id);
+ uint32_t serialized_callback);
+ void OnMsgDelete(const ppapi::HostResource& host_resource,
+ uint32_t serialized_callback);
+ void OnMsgRename(const ppapi::HostResource& file_ref,
+ const ppapi::HostResource& new_file_ref,
+ uint32_t serialized_callback);
- // Host -> Plugin message handlers.
- void OnMsgCallbackComplete(const HostResource& host_resource,
- int callback_id,
- int32_t result);
-
- void OnCallbackCompleteInHost(int32_t result,
- const HostResource& host_resource,
- int callback_id);
-
- pp::CompletionCallbackFactory<PPB_FileRef_Proxy,
- ProxyNonThreadSafeRefCount> callback_factory_;
-
DISALLOW_COPY_AND_ASSIGN(PPB_FileRef_Proxy);
};
« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/ppb_file_ref_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698