Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: net/base/transport_security_state.h

Issue 8364023: Report second-level domains for UMA on pin failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/transport_security_state.cc » ('j') | net/base/transport_security_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/transport_security_state.h
===================================================================
--- net/base/transport_security_state.h (revision 106614)
+++ net/base/transport_security_state.h (working copy)
@@ -128,6 +128,12 @@
static bool IsGooglePinnedProperty(const std::string& host,
bool sni_available);
+ // Report UMA statistics upon pin failure. Reports only down to the
+ // second-level domain of |host| (e.g. google.com), and only if |host| is
wtc 2011/10/25 00:49:57 The example should say something like "google.com
+ // an IsPreloadedSTS host (or, if |sni_available|, an SNI preloaded STS
wtc 2011/10/25 00:49:57 Nit: IsPreloadedSTS is a private method, so it pro
+ // host).
+ static void ReportUMAPinFailure(const std::string& host, bool sni_available);
wtc 2011/10/25 00:49:57 "PinFailure" needs to be more specific, such as "C
+
// Deletes all records created since a given time.
void DeleteSince(const base::Time& time);
« no previous file with comments | « no previous file | net/base/transport_security_state.cc » ('j') | net/base/transport_security_state.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698