Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: chrome/build_nacl_irt.py

Issue 8364019: Activate IRT building on ARM for NaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/nacl.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/build_nacl_irt.py
diff --git a/chrome/build_nacl_irt.py b/chrome/build_nacl_irt.py
index cee765589b38fd9383fde22798f0d85573c1c393..aac0feb884d0df2371359d634ac8c908c827d39e 100755
--- a/chrome/build_nacl_irt.py
+++ b/chrome/build_nacl_irt.py
@@ -163,20 +163,35 @@ def BuildIRT(platforms, out_dir):
# Copy out each platform after stripping.
for platform in platforms:
uplatform = platform.replace('-', '_')
- platform2 = {'x86-32': 'i686', 'x86-64': 'x86_64'}.get(platform, platform)
+ # NaCl Trusted code is in thumb2 mode in CrOS, but as yet,
+ # untrusted code is still in classic ARM mode
+ # arm-thumb2 is for the future when untrusted code is in thumb2 as well
+ platform2 = {'arm': 'pnacl',
+ 'arm-thumb2' : 'pnacl',
+ 'x86-32': 'i686',
+ 'x86-64': 'x86_64'}.get(platform, platform)
cplatform = {
'win32': 'win',
'cygwin': 'win',
'darwin': 'mac',
}.get(sys.platform, 'linux')
nexe = os.path.join(out_dir, 'nacl_irt_' + uplatform + '.nexe')
- cmd = [
- '../native_client/toolchain/' + cplatform + '_x86_newlib/bin/' +
+ if platform in ['arm', 'arm-thumb2']:
+ cmd = [
+ '../native_client/toolchain/pnacl_linux_x86_64_newlib/bin/' +
+ platform2 + '-strip',
+ '--strip-debug',
+ '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
bradn 2011/10/24 19:20:07 >80
+ '-o', nexe
+ ]
+ else:
+ cmd = [
+ '../native_client/toolchain/' + cplatform + '_x86_newlib/bin/' +
platform2 + '-nacl-strip',
- '--strip-debug',
- '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
- '-o', nexe
- ]
+ '--strip-debug',
+ '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
bradn 2011/10/24 19:20:07 >80
+ '-o', nexe
+ ]
print 'Running: ' + ' '.join(cmd)
p = subprocess.Popen(cmd, cwd=SCRIPT_DIR)
p.wait()
« no previous file with comments | « no previous file | chrome/nacl.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698