Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/nacl.gypi

Issue 8364019: Activate IRT building on ARM for NaCl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/build_nacl_irt.py ('K') | « chrome/build_nacl_irt.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/nacl.gypi
diff --git a/chrome/nacl.gypi b/chrome/nacl.gypi
index f5bf28afc0ca4910c429a397807233b070942094..6f13a795772f5183754a4095687ec7de18b0cfaf 100644
--- a/chrome/nacl.gypi
+++ b/chrome/nacl.gypi
@@ -135,6 +135,21 @@
},
],
}],
+ ['OS!="win" and target_arch=="arm"', {
noelallen_use_chromium 2011/10/21 00:16:51 Inconsistent check here. You check for win, but i
jasonwkim 2011/10/21 20:16:56 I am just following the established pattern. First
+ 'actions': [
+ {
+ 'action_name': 'nacl_irt',
+ 'message': 'Building NaCl IRT',
+ 'inputs': [
+ '<!@(<(irt_inputs_cmd) --platform=arm)',
+ ],
+ 'outputs': ['<(PRODUCT_DIR)/nacl_ir.nexe'],
+ 'action': [
+ '<@(irt_build_cmd)', '--platform', 'arm',
+ ],
+ },
+ ],
+ }],
],
},
],
@@ -312,16 +327,21 @@
['target_arch=="x64"', {
'variables': {
'linker_emulation': 'elf_x86_64',
+ 'bootstrap_extra_lib': '',
}
}],
['target_arch=="ia32"', {
'variables': {
'linker_emulation': 'elf_i386',
+ 'bootstrap_extra_lib': '',
}
}],
['target_arch=="arm"', {
'variables': {
'linker_emulation': 'armelf_linux_eabi',
+ # ARM requires linking against libc due to ABI dependencies on
+ # memset
+ 'bootstrap_extra_lib' : "${SYSROOT}/usr/lib/libc.a",
}
}],
],
@@ -344,6 +364,7 @@
'-z', 'max-page-size=0x1000',
'--whole-archive', '<(bootstrap_lib)',
'--no-whole-archive',
+ '<(bootstrap_extra_lib)',
],
}
],
« chrome/build_nacl_irt.py ('K') | « chrome/build_nacl_irt.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698