Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 8364018: Enable privileged WebGL extensions for Chrome extensions. (Closed)

Created:
9 years, 2 months ago by Zhenyao Mo
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable privileged WebGL extensions for Chrome extensions. Also, these WebGL extensions can be enabled through a commandline switch: enable-privileged-webgl-extensions. BUG=95531 TEST=two WebGL conformance tests run through the extension-enabled path Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/extensions/extension_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
Aaron, I will merge the extension part after you land your refactoring CL tonight. Ken, ...
9 years, 2 months ago (2011-10-20 21:58:28 UTC) #1
Ken Russell (switch to Gerrit)
Nice! LGTM.
9 years, 2 months ago (2011-10-20 23:24:50 UTC) #2
Aaron Boodman
lgtm You can land this, but please be aware that your webgl extensions will only ...
9 years, 2 months ago (2011-10-21 20:15:58 UTC) #3
Zhenyao Mo
On 2011/10/21 20:15:58, Aaron Boodman wrote: > lgtm > > You can land this, but ...
9 years, 2 months ago (2011-10-21 20:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/8364018/1
9 years, 2 months ago (2011-10-22 00:39:18 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-22 00:39:22 UTC) #6
Presubmit check for 8364018-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/public/common/content_switches.h,content/common/view_messages.h,content/public/common/content_switches.cc

Presubmit checks took 1.4s to calculate.

Powered by Google App Engine
This is Rietveld 408576698