Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/autocomplete/autocomplete_match.h

Issue 8364001: Strip special characters in extension omnibox suggestions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_match.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_match.h (revision 107110)
+++ chrome/browser/autocomplete/autocomplete_match.h (working copy)
@@ -124,6 +124,10 @@
int style,
ACMatchClassifications* classifications);
+ // Removes invalid characters from |str|. Should be called on strings coming
+ // from external sources (such as extensions) before assigning to |contents|.
Peter Kasting 2011/10/25 20:37:07 Nit: ... or |description|.
Alexei Svitkine (slow) 2011/10/25 21:37:16 Done.
+ static string16 SanitizeString(const string16& str);
Peter Kasting 2011/10/25 20:37:07 Nit: For consistency with other functions, call th
Alexei Svitkine (slow) 2011/10/25 21:37:16 Done.
+
// The provider of this match, used to remember which provider the user had
// selected when the input changes. This may be NULL, in which case there is
// no provider (or memory of the user's selection).

Powered by Google App Engine
This is Rietveld 408576698